HattiiCD
Hyper Soinic
Im trans ig
Posts: 306 
|
Post by HattiiCD on Mar 6, 2023 9:07:40 GMT -6
Is it compatible with ESS? Even if its not, its pretty rad.
|
|
|
|
Post by BlueFrost on Mar 6, 2023 11:04:53 GMT -6
Well I guess it feels like SRB2.
|
|
|
|
Post by Wonder Power on Mar 6, 2023 13:07:00 GMT -6
The update brought some regressions that broke the Mania animated signposts. My suggestion is this, it makes this function less restrictive to fix it, but it's your call of course: function string getCharacterSignpostSpriteKey(u8 character)
{
// Special handling for active extra character
if (global.xtrachar > CHARACTER_UNSET && isMainCharacter(character))
{
return stringformat("signpost_slot%d", global.xtrachar)
}
// Call the base function
return base.getCharacterSignpostSpriteKey(character)
}But anyway, great job as always!  |
|
Geared
Flicky
An goofy Sonic fan around the forums
Posts: 38 
|
Post by Geared on Mar 6, 2023 13:08:14 GMT -6
oh boy, i cannot await for 255 extra slot recolors!
|
|
|
|
Post by montydoesgames on Mar 6, 2023 14:26:13 GMT -6
This is a sign. A sign of something sweet as a flower, but can pound you into the floor.
|
|
iCloudius
Cluckoid
Extra Slots or something?
Posts: 174
|
Post by iCloudius on Mar 6, 2023 15:21:23 GMT -6
The update brought some regressions that broke the Mania animated signposts. My suggestion is this, it makes this function less restrictive to fix it, but it's your call of course: function string getCharacterSignpostSpriteKey(u8 character)
{
// Special handling for active extra character
if (global.xtrachar > CHARACTER_UNSET && isMainCharacter(character))
{
return stringformat("signpost_slot%d", global.xtrachar)
}
// Call the base function
return base.getCharacterSignpostSpriteKey(character)
}But anyway, great job as always! Thank you. I'm glad you're enjoying it. If you don't mind me asking, how are you using the mania animated signposts? They should be under the characters? |
|
|
|
Post by Wonder Power on Mar 6, 2023 15:44:50 GMT -6
How are you using the mania animated signposts? They should be under the characters? They are under the characters' mods. The animated mania signpost mod doesn't have any override for that function, so it will call the ESU framework's override independently of the load order. And any character value that passes onto it, it will always return the string for the ES character, so in this part of it's code: u64 expected = (character == CHARACTER_SONIC) ? "signpost_sonic" : (character == CHARACTER_TAILS) ? "signpost_tails" : "signpost_knuckles"
// this mofo dont got a signpost sprite
if (getCharacterSignpostSpriteKey(character) == expected && character == maniasignpost_char)
return "maniainsp_signpost_generic"
else
return key
It will return the fallback signpost for any plaque that isn't the playable ES character (when playing as an ES character) with the correct load order. |
|
iCloudius
Cluckoid
Extra Slots or something?
Posts: 174
|
Post by iCloudius on Mar 6, 2023 15:48:54 GMT -6
How are you using the mania animated signposts? They should be under the characters? They are under the characters' mods. The animated mania signpost mod doesn't have any override for that function, so it will call the ESU framework's override independently of the load order. And any character value that passes onto it, it will always return the string for the ES character, so in this part of it's code: u64 expected = (character == CHARACTER_SONIC) ? "signpost_sonic" : (character == CHARACTER_TAILS) ? "signpost_tails" : "signpost_knuckles"
// this mofo dont got a signpost sprite
if (getCharacterSignpostSpriteKey(character) == expected && character == maniasignpost_char)
return "maniainsp_signpost_generic"
else
return key
It will return the fallback signpost for any plaque that isn't the playable ES character (when playing as an ES character) with the correct load order. I see. You're suggesting that I use the code you listed above for my animated signposts mod? I just wanna make sure I understand you. |
|
|
|
Post by rrllmm on Mar 6, 2023 15:52:43 GMT -6
Omg its real
|
|
|
|
Post by Wonder Power on Mar 6, 2023 15:54:11 GMT -6
I see. You're suggesting that I use the code you listed above for my animated signposts mod? I just wanna make sure I understand you. Oh sorry, i probably wasn't clear about it. The first post has a suggested fix for the ESU Framework so that mods like Dynamic Lemons's "Mania Inspired Signpost Animation" continue to work properly after the latest ESU Framework update. I didn't play this version of the framework with your own animated signposts yet. |
|
iCloudius
Cluckoid
Extra Slots or something?
Posts: 174
|
Post by iCloudius on Mar 6, 2023 16:00:04 GMT -6
I see. You're suggesting that I use the code you listed above for my animated signposts mod? I just wanna make sure I understand you. Oh sorry, i probably wasn't clear about it. The first post has a suggested fix for the ESU Framework so that mods like Dynamic Lemons's "Mania Inspired Signpost Animation" continue to work properly after the latest ESU Framework update. I didn't play this version of the framework with your own animated signposts yet. Alright. I've used his mod too and everything seems to work with the latest revision of ESU. Also, the fix you suggested seems to break ES Character's signposts. |
|
MrPro
Spikes
hi
Posts: 10
|
Post by MrPro on Mar 6, 2023 16:09:02 GMT -6
its finally here
|
|
|
|
Post by Wonder Power on Mar 6, 2023 16:12:50 GMT -6
Alright. I've used his mod too and everything seems to work with the latest revision of ESU. Also, the fix you suggested seems to break ES Character's signposts. That's weird it fixed for me and didn't break the base signposts with that mania signpost mod unloaded. I might have something that's not updated, this is what i have by load order - Extra Slot Mighty 5.0 - Extra Slot Ray 2.0 - Extra Characters Slots 8.0 - Mania Inspired Signpost Animation 1.0 A.I.R itself it's on 22.09.10 If you can't find anything strange, I'll keep my own setup like this and update you if I find if the real reason for this is a real bug and not something dumb made by me EDIT: Scratch that, i doesn't break Mighty but it does break Ray, I'll look deeper into it next time i have a bit more time. |
|
iCloudius
Cluckoid
Extra Slots or something?
Posts: 174
|
Post by iCloudius on Mar 6, 2023 16:17:49 GMT -6
Alright. I've used his mod too and everything seems to work with the latest revision of ESU. Also, the fix you suggested seems to break ES Character's signposts. That's weird it fixed for me and didn't break the base signposts with that mania signpost mod unloaded. I might have something that's not updated, this is what i have by load order - Extra Slot Mighty 5.0 - Extra Slot Ray 2.0 - Extra Characters Slots 8.0 - Mania Inspired Signpost Animation 1.0 A.I.R itself it's on 22.09.10 If you can't find anything strange, I'll keep my own setup like this and update you if I find if the real reason for this is a real bug and not something dumb made by me The Mania Inspired Signpost Animations were updated to 1.1 back in early February on the Discord. |
|
|
|
Post by Guhtati_ on Mar 6, 2023 16:25:53 GMT -6
Eh, and there we go.
|
|
